Christian Borntraeger <borntraeger@xxxxxxxxxxxxx> writes: > in rare cases, e.g. for injecting a machine check we do intercept all > load PSW instructions via ICTL_LPSW. With facility 193 a new variant > LPSWEY was added. KVM needs to handle that as well. > > Fixes: a3efa8429266 ("KVM: s390: gen_facilities: allow facilities 165, 193, 194 and 196") > Reported-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx> > Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxxxxx> > --- > arch/s390/include/asm/kvm_host.h | 1 + > arch/s390/kvm/kvm-s390.c | 1 + > arch/s390/kvm/kvm-s390.h | 15 +++++++++++++++ > arch/s390/kvm/priv.c | 32 ++++++++++++++++++++++++++++++++ > 4 files changed, 49 insertions(+) > > diff --git a/arch/s390/kvm/kvm-s390.h b/arch/s390/kvm/kvm-s390.h > index 111eb5c74784..1b326f3c3383 100644 > --- a/arch/s390/kvm/kvm-s390.h > +++ b/arch/s390/kvm/kvm-s390.h > @@ -138,6 +138,21 @@ static inline u64 kvm_s390_get_base_disp_s(struct kvm_vcpu *vcpu, u8 *ar) > return (base2 ? vcpu->run->s.regs.gprs[base2] : 0) + disp2; > } > > +static inline u64 kvm_s390_get_base_disp_siy(struct kvm_vcpu *vcpu, u8 *ar) > +{ > + u32 base1 = vcpu->arch.sie_block->ipb >> 28; > + s64 disp1; > + Whitespace error. With that removed: Reviewed-by: Sven Schnelle <svens@xxxxxxxxxxxxx> > + /* The displacement is a 20bit _SIGNED_ value */ > + disp1 = sign_extend64(((vcpu->arch.sie_block->ipb & 0x0fff0000) >> 16) + > + ((vcpu->arch.sie_block->ipb & 0xff00) << 4), 19); > + > + if (ar) > + *ar = base1; > + > + return (base1 ? vcpu->run->s.regs.gprs[base1] : 0) + disp1; > +}