On Thu, Jun 06, 2024, Vasant Karasulli wrote: > On Mi 05-06-24 09:04:04, Sean Christopherson wrote: > > On Fri, Apr 19, 2024, vsntk18@xxxxxxxxx wrote: > > > From: Vasant Karasulli <vkarasulli@xxxxxxx> > > > > > > Processing CPUID #VC for AMD SEV-ES requires copying xcr0 into GHCB. > > > Move the xsave read/write helpers used by xsave testcase to lib/x86 > > > to share as common code. > > > > This doesn't make any sense, processor.h _is_ common code. And using > > get_supported_xcr0(), which does CPUID, in a #VC handler is even more nonsensical. > > Indeed, it's still used only by test_xsave() at the end of this series. > > > > The idea was to have xcr0 related declarations and definitions in the same place > which were distributed across files. Does that make sense to you? If not > I will move back get_supported_xcr0() to where it was. I don't necessarily disagree with that approach, but I don't think we need a dedicated xsave.h, e.g. just move get_supported_xcr0() to processor.h.
