On Mi 05-06-24 09:04:04, Sean Christopherson wrote: > On Fri, Apr 19, 2024, vsntk18@xxxxxxxxx wrote: > > From: Vasant Karasulli <vkarasulli@xxxxxxx> > > > > Processing CPUID #VC for AMD SEV-ES requires copying xcr0 into GHCB. > > Move the xsave read/write helpers used by xsave testcase to lib/x86 > > to share as common code. > > This doesn't make any sense, processor.h _is_ common code. And using > get_supported_xcr0(), which does CPUID, in a #VC handler is even more nonsensical. > Indeed, it's still used only by test_xsave() at the end of this series. > The idea was to have xcr0 related declarations and definitions in the same place which were distributed across files. Does that make sense to you? If not I will move back get_supported_xcr0() to where it was. > > Signed-off-by: Varad Gautam <varad.gautam@xxxxxxxx> > > Signed-off-by: Vasant Karasulli <vkarasulli@xxxxxxx> > > Reviewed-by: Marc Orr <marcorr@xxxxxxxxxx> > > --- > > lib/x86/processor.h | 10 ---------- > > lib/x86/xsave.c | 26 ++++++++++++++++++++++++++ > > lib/x86/xsave.h | 15 +++++++++++++++ > > x86/Makefile.common | 1 + > > x86/xsave.c | 17 +---------------- > > 5 files changed, 43 insertions(+), 26 deletions(-) > > create mode 100644 lib/x86/xsave.c > > create mode 100644 lib/x86/xsave.h -- Vasant Karasulli Kernel generalist www.suse.com<http://www.suse.com> [https://www.suse.com/assets/img/social-platforms-suse-logo.png]<http://www.suse.com/> SUSE - Open Source Solutions for Enterprise Servers & Cloud<http://www.suse.com/> Modernize your infrastructure with SUSE Linux Enterprise servers, cloud technology for IaaS, and SUSE's software-defined storage. www.suse.com
