On Tue, May 07, 2024 at 10:28:34AM +0800, Yi Liu wrote: > > > We still need something to do before we can safely remove this check. > > > All the domain allocation interfaces should eventually have the device > > > pointer as the input, and all domain attributions could be initialized > > > during domain allocation. In the attach paths, it should return -EINVAL > > > directly if the domain is not compatible with the iommu for the device. > > > > Yes, and this is already true for PASID. > > I'm not quite get why it is already true for PASID. I think Baolu's remark > is general to domains attached to either RID or PASID. > > > I feel we could reasonably insist that domanis used with PASID are > > allocated with a non-NULL dev. > > Any special reason for this disclaim? If it makes the driver easier, why not? PASID is special since PASID is barely used, we could insist that new PASID users also use the new domian_alloc API. > I agree implementing alloc_domain_paging() is the final solution to avoid > such dynamic modifications to domain's caps. If it's really needed for > PASID series now, I can add it in next version. :) Well, if it is needed. If you can do this some other way that is reasonable then sure Jason
