On Sun, May 5, 2024 at 6:37 PM Mi, Dapeng <dapeng1.mi@xxxxxxxxxxxxxxx> wrote: > > > On 5/1/2024 2:15 AM, Mingwei Zhang wrote: > > On Mon, Apr 29, 2024 at 5:45 PM Dapeng Mi <dapeng1.mi@xxxxxxxxxxxxxxx> wrote: > >> This small patchset refines the ambiguous naming in kvm_pmu structure > >> and use macros instead of magic numbers to manipulate FIXED_CTR_CTRL MSR > >> to increase readability. > >> > >> No logic change is introduced in this patchset. > >> > >> Dapeng Mi (2): > >> KVM: x86/pmu: Change ambiguous _mask suffix to _rsvd in kvm_pmu > > So, it looks like the 1st patch is also in the upcoming RFCv2 for > > mediated passthrough vPMU. I will remove that from my list then. > > Mingwei, we'd better keep this patch in RFCv2 until the this patchset is > merged, then we don't rebase it again when this patch is merged. Thanks. > yeah. too late. I don't want to have a duplicate patch in LKML. On the other hand, you could have waited a little bit before sending this one. Next time, coordinate with us before sending. Thanks. -Mingwei > > > Thanks. Regards > > -Mingwei > > > >> KVM: x86/pmu: Manipulate FIXED_CTR_CTRL MSR with macros > >> > >> arch/x86/include/asm/kvm_host.h | 10 ++++----- > >> arch/x86/kvm/pmu.c | 26 ++++++++++++------------ > >> arch/x86/kvm/pmu.h | 8 +++++--- > >> arch/x86/kvm/svm/pmu.c | 4 ++-- > >> arch/x86/kvm/vmx/pmu_intel.c | 36 +++++++++++++++++++-------------- > >> 5 files changed, 46 insertions(+), 38 deletions(-) > >> > >> > >> base-commit: 7b076c6a308ec5bce9fc96e2935443ed228b9148 > >> -- > >> 2.40.1 > >>