On Fri, Apr 26, 2024, Rick P Edgecombe wrote: > On Fri, 2024-04-26 at 09:49 -0700, Sean Christopherson wrote: > > > > Heh, where's your bitmask abuse spirit? It's a little evil (and by "evil" > > I mean awesome), but the need to process different roots is another good > > argument for an enum+bitmask. > > Haha. There seems to be some special love for bit math in KVM. I was just > relaying my struggle to understand permission_fault() the other day. LOL, you and everyone else that's ever looked at that code. Just wait until you run into one of Paolo's decimal-based bitmasks.