On Wed, Apr 24, 2024 at 12:24:19AM +0000, Tian, Kevin wrote: > > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > > Sent: Tuesday, April 23, 2024 8:40 PM > > > > On Fri, Apr 12, 2024 at 01:21:21AM -0700, Yi Liu wrote: > > > Today, vfio-pci hides the PASID capability of devices from userspace. Unlike > > > other PCI capabilities, PASID capability is going to be reported to user by > > > VFIO_DEVICE_FEATURE. Hence userspace could probe PASID capability by > > it. > > > This is a bit different from the other capabilities which are reported to > > > userspace when the user reads the device's PCI configuration space. There > > > are two reasons for this. > > > > I'm thinking this probably does not belong in VFIO, iommufd should > > report what the device, driver and OS is able to do with this > > device. PASID support is at least 50% an iommu property too. > > We have PASID capability in both device side and iommu side. > > VFIO is for the former and iommufd is for the latter. iommu can do the device side too, we have a device info ioctl after all. Jason
