On Fri, Apr 12, 2024 at 01:21:21AM -0700, Yi Liu wrote: > Today, vfio-pci hides the PASID capability of devices from userspace. Unlike > other PCI capabilities, PASID capability is going to be reported to user by > VFIO_DEVICE_FEATURE. Hence userspace could probe PASID capability by it. > This is a bit different from the other capabilities which are reported to > userspace when the user reads the device's PCI configuration space. There > are two reasons for this. I'm thinking this probably does not belong in VFIO, iommufd should report what the device, driver and OS is able to do with this device. PASID support is at least 50% an iommu property too. This is a seperate issue to forming the config space. I didn't notice anything about SIOV in this, are we tackling it later? IIRC we need the vIOMMU to specify a vPASID during attach and somehow that gets mapped into a pPASID and synchronized with the KVM ENQCMD translation? Jason