On Thu, Mar 14, 2024 at 03:45:49PM +0800, Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx> wrote: > > > On 2/27/2024 3:27 AM, Isaku Yamahata wrote: > > On Mon, Feb 26, 2024 at 12:25:30AM -0800, > > isaku.yamahata@xxxxxxxxx wrote: > > > > > diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h > > > index fdfd41511b02..28c4a62b7dba 100644 > > > --- a/arch/x86/include/asm/shared/tdx.h > > > +++ b/arch/x86/include/asm/shared/tdx.h > > > @@ -26,7 +26,13 @@ > > > #define TDVMCALL_GET_QUOTE 0x10002 > > > #define TDVMCALL_REPORT_FATAL_ERROR 0x10003 > > > -#define TDVMCALL_STATUS_RETRY 1 > > Oops, I accidentally removed this constant to break tdx guest build. > > Is this the same as "TDVMCALL_RETRY" added in the patch? Since both tdx > guest code and VMM share the same header file, maybe it needs another patch > to change the code in guest or you just follow the naming style of the exist > code? The style in other TDX place is without STATUS. I don't want to play bike shedding. For now I'd like to leave TDVMCALL_STATUS_RETRY, not add TDVMCALL_RETRY, and keep other TDVMCALL_*. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
