Re: [PATCH v19 028/130] KVM: TDX: Add TDX "architectural" error codes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2/27/2024 3:27 AM, Isaku Yamahata wrote:
On Mon, Feb 26, 2024 at 12:25:30AM -0800,
isaku.yamahata@xxxxxxxxx wrote:

diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h
index fdfd41511b02..28c4a62b7dba 100644
--- a/arch/x86/include/asm/shared/tdx.h
+++ b/arch/x86/include/asm/shared/tdx.h
@@ -26,7 +26,13 @@
  #define TDVMCALL_GET_QUOTE		0x10002
  #define TDVMCALL_REPORT_FATAL_ERROR	0x10003
-#define TDVMCALL_STATUS_RETRY 1
Oops, I accidentally removed this constant to break tdx guest build.

Is this the same as "TDVMCALL_RETRY" added in the patch? Since both tdx guest code and VMM share the same header file, maybe it needs another patch to change the code in guest or you just follow the naming style of the exist code?

diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h
index ef1c8e5a2944..1367a5941499 100644
--- a/arch/x86/include/asm/shared/tdx.h
+++ b/arch/x86/include/asm/shared/tdx.h
@@ -28,6 +28,8 @@
  #define TDVMCALL_REPORT_FATAL_ERROR    0x10003
  #define TDVMCALL_SETUP_EVENT_NOTIFY_INTERRUPT  0x10004
+#define TDVMCALL_STATUS_RETRY 1
+
  /*
   * TDG.VP.VMCALL Status Codes (returned in R10)
   */





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux