Hi Xiaoyao, On Sat, Mar 09, 2024 at 09:48:34PM +0800, Xiaoyao Li wrote: > Date: Sat, 9 Mar 2024 21:48:34 +0800 > From: Xiaoyao Li <xiaoyao.li@xxxxxxxxx> > Subject: Re: [PATCH v9 08/21] i386/cpu: Consolidate the use of topo_info in > cpu_x86_cpuid() > > On 2/27/2024 6:32 PM, Zhao Liu wrote: > > From: Zhao Liu<zhao1.liu@xxxxxxxxx> > > > > In cpu_x86_cpuid(), there are many variables in representing the cpu > > topology, e.g., topo_info, cs->nr_cores and cs->nr_threads. > > > > Since the names of cs->nr_cores/cs->nr_threads does not accurately > > Again as in v7, please changes to "cs->nr_cores and cs->nr_threads", > > "cs->nr_cores/cs->nr_threads" looks like a single variable of division > I missed to change this. Though, TBH, legitimate division operations are going to add spaces around "/". It's also common practice to represent "or" by "/" w/t spaces. But I'll change it in the next version to make you happy! Thanks, Zhao
