On 2/27/2024 6:32 PM, Zhao Liu wrote:
From: Zhao Liu<zhao1.liu@xxxxxxxxx> In cpu_x86_cpuid(), there are many variables in representing the cpu topology, e.g., topo_info, cs->nr_cores and cs->nr_threads. Since the names of cs->nr_cores/cs->nr_threads does not accurately
Again as in v7, please changes to "cs->nr_cores and cs->nr_threads", "cs->nr_cores/cs->nr_threads" looks like a single variable of division
represent its meaning, the use of cs->nr_cores/cs->nr_threads is prone to confusion and mistakes. And the structure X86CPUTopoInfo names its members clearly, thus the variable "topo_info" should be preferred. In addition, in cpu_x86_cpuid(), to uniformly use the topology variable, replace env->dies with topo_info.dies_per_pkg as well.