On 14/11/23 16:49, David Woodhouse wrote:
On 14 November 2023 09:38:06 GMT-05:00, "Philippe Mathieu-Daudé" <philmd@xxxxxxxxxx> wrote:
To avoid a potential global variable shadow in
hw/i386/pc_piix.c::pc_init1(), rename Xen's
"ram_memory" as "xen_memory".
Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
Well OK, but aren't you going to be coming back later to eliminate global variables which are actually per-VM?
Or is that the point, because *then* the conflicting name will actually matter?
Eh I wasn't thinking about running 2 Xen VMs in the same QEMU process,
but this is a good test case. I was thinking of running a Xen guest VM
and another TCG VM in the same process.
So IIUC xen_memory should be part of PCMachineState.
Reviewed-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
Thanks!
