On 14 November 2023 09:38:06 GMT-05:00, "Philippe Mathieu-Daudé" <philmd@xxxxxxxxxx> wrote: >To avoid a potential global variable shadow in >hw/i386/pc_piix.c::pc_init1(), rename Xen's >"ram_memory" as "xen_memory". > >Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> Well OK, but aren't you going to be coming back later to eliminate global variables which are actually per-VM? Or is that the point, because *then* the conflicting name will actually matter? Reviewed-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
