On 18.12.23 11:23, Andy Shevchenko wrote: > On Fri, Dec 15, 2023 at 11:06:08PM +0100, Peter Hilber wrote: >> Add a clocksource ID for the x86 kvmclock. >> >> Also, for ptp_kvm, set the recently added struct system_counterval_t member >> cs_id to the clocksource ID (x86 kvmclock or Arm Generic Timer). In the >> future, this will keep get_device_system_crosststamp() working, when it >> will compare the clocksource id in struct system_counterval_t, rather than >> the clocksource. >> >> For now, to avoid touching too many subsystems at once, extract the >> clocksource ID from the clocksource. The clocksource dereference will be >> removed in the following. > > ... > >> #include <linux/clocksource.h> >> +#include <linux/clocksource_ids.h> > > It's the second file that includes both. > > I'm just wondering if it makes sense to always (?) include the latter into > the former. > Actually, clocksource.h already includes clocksource_ids.h, always since the latter was created. So I'll just omit the unnecessary clocksource_ids.h includes in other files. Thanks for the comment, Peter
