Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Tue, 12 Dec 2023 14:38:02 +0100
Cc: "Graf (AWS), Alexander" <graf@xxxxxxxxx>, "seanjc@xxxxxxxxxx" <seanjc@xxxxxxxxxx>, "ebiederm@xxxxxxxxxxxx" <ebiederm@xxxxxxxxxxxx>, Schönherr, Jan H. <jschoenh@xxxxxxxxx>, "yuzenghui@xxxxxxxxxx" <yuzenghui@xxxxxxxxxx>, "kexec@xxxxxxxxxxxxxxxxxxx" <kexec@xxxxxxxxxxxxxxxxxxx>, "kvm-riscv@xxxxxxxxxxxxxxxxxxx" <kvm-riscv@xxxxxxxxxxxxxxxxxxx>, "james.morse@xxxxxxx" <james.morse@xxxxxxx>, "oliver.upton@xxxxxxxxx" <oliver.upton@xxxxxxxxx>, "suzuki.poulose@xxxxxxx" <suzuki.poulose@xxxxxxx>, "chenhuacai@xxxxxxxxxx" <chenhuacai@xxxxxxxxxx>, "atishp@xxxxxxxxxxxxxx" <atishp@xxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "maz@xxxxxxxxxx" <maz@xxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "kvmarm@xxxxxxxxxxxxxxx" <kvmarm@xxxxxxxxxxxxxxx>, "aleksandar.qemu.devel@xxxxxxxxx" <aleksandar.qemu.devel@xxxxxxxxx>, "anup@xxxxxxxxxxxxxx" <anup@xxxxxxxxxxxxxx>
In-reply-to: <cf9e15bf3da411ada1c5b2bbdbfdea836029a5e1.camel@amazon.com>
References: <20230512233127.804012-1-seanjc@google.com> <20230512233127.804012-2-seanjc@google.com> <cfed942fc767fa7b2fabc68a3357a7b95bd6a589.camel@amazon.com> <871qbud5f9.fsf@email.froward.int.ebiederm.org> <a02b40d3d9ae5b3037b9a9d5921cfb0144ab5610.camel@amazon.com> <7e30cfc2359dfef39d038e3734f7e5e3d9e82d68.camel@amazon.com> <87wmtk9u46.fsf@email.froward.int.ebiederm.org> <cf9e15bf3da411ada1c5b2bbdbfdea836029a5e1.camel@amazon.com>

On Tue, Dec 12, 2023 at 9:51 AM Gowans, James <jgowans@xxxxxxxxxx> wrote:
> 1. Does hardware_disable_nolock actually need to be done on *every* CPU
> or would the offlined ones be fine to ignore because they will be reset
> and the VMXE bit will be cleared that way? With cooperative CPU handover
> we probably do indeed want to do this on every CPU and not depend on
> resetting.

Offlined and onlined CPUs are handled via the CPU hotplug state machine,
which calls into kvm_online_cpu and kvm_offline_cpu.

Paolo

References:
- [PATCH v2 0/2] KVM: Fix race between reboot and hardware enabling
  - From: Sean Christopherson
- [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
  - From: Sean Christopherson
- Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
  - From: Gowans, James
- Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
  - From: Eric W. Biederman
- Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
  - From: Gowans, James
- Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
  - From: Gowans, James
- Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
  - From: Eric W. Biederman
- Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
  - From: Gowans, James

Prev by Date: Re: Should I add BPF kfuncs for userspace apps? And how?
Next by Date: RE: [PATCH v6 2/6] iommufd: Add IOMMU_HWPT_INVALIDATE
Previous by thread: Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
Next by thread: Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]