On 04/25/2010 06:07 PM, Jan Kiszka wrote:
The fact that the API assumes a single user is what's broken IMO.
If the API were to take a memory slot as parameter you could say it is
the responsibility of the slot's owner to multiplex (and since vga has a
single owner, no need to multiplex). But it takes a range.
No, the API accepts only a single slot. If you try passing bogus ranges
that span multiple or incomplete slots, you get what you deserve - a bug
message.
I see. In its qemu-kvm iteration, it would iterate over slots and
accept incomplete slots (it's okay to log more than requested). If the
API is for a slot, it should accept a slot, not a range (when we move to
a slots representation in qemu).
Unrelated:
cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa0000, 0xa8000);
cpu_physical_sync_dirty_bitmap(isa_mem_base + 0xa8000, 0xb0000);
Will this sync to the right place (whatever those windows alias to)?
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
