On Mon, Oct 23, 2023 at 06:50:05PM +0100, Joao Martins wrote: > On 23/10/2023 14:12, Jason Gunthorpe wrote: > > On Mon, Oct 23, 2023 at 01:37:28PM +0100, Joao Martins wrote: > > > >> iommufd Kconfig is only included in the IOMMU_SUPPORT kconfig if clause; so > >> moving it out from the iommufd kconfig out into iommu kconfig should fix it. > >> Didn't realize that one can select IOMMU_API yet have IOMMU_SUPPORT unset/unmet. > >> I'll make the move in v6 > > > > I think this is some cruft that accumulated over the years, it doesn't > > make alot of sense that there are two kconfigs now.. > > To be specific what I meant to move is the IOMMUFD_DRIVER kconfig part, not the > whole iommufd Kconfig [in the patch introducing the problem] e.g. yes > Perhaps the merging of IOMMU_API with IOMMU_SUPPORT should be best done separately? Yes Jason