From: Arnd Bergmann <arnd@xxxxxxxx> Selecting IOMMUFD_DRIVER is not allowed if IOMMUs themselves are not supported: WARNING: unmet direct dependencies detected for IOMMUFD_DRIVER Depends on [n]: IOMMU_SUPPORT [=n] Selected by [m]: - MLX5_VFIO_PCI [=m] && VFIO [=y] && PCI [=y] && MMU [=y] && MLX5_CORE [=y] There is no actual build failure, only the warning. Make the 'select' conditional using the same logic that we have for INTEL_IOMMU and AMD_IOMMU. Fixes: 33f6339534287 ("vfio: Move iova_bitmap into iommufd") Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> --- drivers/vfio/pci/mlx5/Kconfig | 2 +- drivers/vfio/pci/pds/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vfio/pci/mlx5/Kconfig b/drivers/vfio/pci/mlx5/Kconfig index c3ced56b77876..c23815c486a75 100644 --- a/drivers/vfio/pci/mlx5/Kconfig +++ b/drivers/vfio/pci/mlx5/Kconfig @@ -3,7 +3,7 @@ config MLX5_VFIO_PCI tristate "VFIO support for MLX5 PCI devices" depends on MLX5_CORE select VFIO_PCI_CORE - select IOMMUFD_DRIVER + select IOMMUFD_DRIVER if IOMMUFD help This provides migration support for MLX5 devices using the VFIO framework. diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig index fec9b167c7b9a..6091e11f0e521 100644 --- a/drivers/vfio/pci/pds/Kconfig +++ b/drivers/vfio/pci/pds/Kconfig @@ -5,7 +5,7 @@ config PDS_VFIO_PCI tristate "VFIO support for PDS PCI devices" depends on PDS_CORE && PCI_IOV select VFIO_PCI_CORE - select IOMMUFD_DRIVER + select IOMMUFD_DRIVER if IOMMUFD help This provides generic PCI support for PDS devices using the VFIO framework. -- 2.39.2