RE: [PATCH v4 05/18] iommufd: Add a flag to enforce dirty tracking on attach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Joao Martins <joao.m.martins@xxxxxxxxxx>
> Sent: Thursday, October 19, 2023 7:39 AM
> 
> On 18/10/2023 23:38, Jason Gunthorpe wrote:
> > On Wed, Oct 18, 2023 at 09:27:02PM +0100, Joao Martins wrote:
> >> Throughout IOMMU domain lifetime that wants to use dirty tracking,
> some
> >> guarantees are needed such that any device attached to the
> iommu_domain
> >> supports dirty tracking.
> >>
> >> The idea is to handle a case where IOMMU in the system are assymetric
> >> feature-wise and thus the capability may not be supported for all devices.
> >> The enforcement is done by adding a flag into HWPT_ALLOC namely:
> >>
> >> 	IOMMUFD_HWPT_ALLOC_ENFORCE_DIRTY
> >
> > Actually, can we change this name?
> >
> > IOMMUFD_HWPT_ALLOC_DIRTY_TRACKING
> >
> > ?
> >
> Yeap.
> 

Agree. Please also adjust the related texts in commit msg and code
comments.

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux