On 18/10/2023 23:38, Jason Gunthorpe wrote: > On Wed, Oct 18, 2023 at 09:27:02PM +0100, Joao Martins wrote: >> Throughout IOMMU domain lifetime that wants to use dirty tracking, some >> guarantees are needed such that any device attached to the iommu_domain >> supports dirty tracking. >> >> The idea is to handle a case where IOMMU in the system are assymetric >> feature-wise and thus the capability may not be supported for all devices. >> The enforcement is done by adding a flag into HWPT_ALLOC namely: >> >> IOMMUFD_HWPT_ALLOC_ENFORCE_DIRTY > > Actually, can we change this name? > > IOMMUFD_HWPT_ALLOC_DIRTY_TRACKING > > ? > Yeap. > There isnt' really anything 'enforce' here, it just creates a domain > that will always allow the eventual IOMMU_DIRTY_TRACKING_ENABLE no > matter what it is attached to. > The 'enforce' part comes from the fact that device being attached in domain_alloc_user() will require dirty tracking before it can succeed. Still your flag name looks better anyhow > That is the same as the other domain flags like NEST_PARENT > > Jason
