On Thu, Oct 12, 2023 at 10:43:30AM +0100, James Clark wrote: > ARMV8_PMU_EVTYPE_MASK is still used in access_pmu_evtyper() and > reset_pmevtyper(), although it's not really an issue if you can't set > the bits in the first place. But it probably makes sense to use the same > mask everywhere. Agreed. Well, the masking done for reads in access_pmu_evtyper() is pointless since we sanitise the value when written. I'll update reset_pmevtyper() though. -- Thanks, Oliver