Re: [PATCH v21 01/20] s390x/cpu topology: add s390 specifics to CPU topology

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 7/24/23 12:15, Nina Schoetterl-Glausch wrote:
On Fri, 2023-07-21 at 13:24 +0200, Pierre Morel wrote:
On 7/18/23 18:31, Nina Schoetterl-Glausch wrote:
Reviewed-by: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx>

Some notes below.

The s390x/ prefix in the title might suggest that this patch
is s390 specific, but it touches common files.

Right.

What do you suggest?

I can cut it in two or squash it with patch number 2.

The first idea was to separate the patch to ease the review but the
functionality introduced in patch 1 do only make sense with patch 2.

So I would be for squashing the first two patches.

?
Oh, I'd just change the title.

CPU topology: extend with s390 specifics

or similar, it was just a nit not to create the impression that the
patch only touches s390 stuff.


OK thanks

Pierre






[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux