On Fri, 2023-07-21 at 13:24 +0200, Pierre Morel wrote: > > On 7/18/23 18:31, Nina Schoetterl-Glausch wrote: > > Reviewed-by: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx> > > > > Some notes below. > > > > The s390x/ prefix in the title might suggest that this patch > > is s390 specific, but it touches common files. > > > Right. > > What do you suggest? > > I can cut it in two or squash it with patch number 2. > > The first idea was to separate the patch to ease the review but the > functionality introduced in patch 1 do only make sense with patch 2. > > So I would be for squashing the first two patches. > > ? Oh, I'd just change the title. CPU topology: extend with s390 specifics or similar, it was just a nit not to create the impression that the patch only touches s390 stuff. > > > > > > On Fri, 2023-06-30 at 11:17 +0200, Pierre Morel wrote: > > > S390 adds two new SMP levels, drawers and books to the CPU > > > topology. > > > The S390 CPU have specific topology features like dedication > > S390 CPUs have specific topology features like dedication and > > entitlement. These indicate to the guest information on host > > vCPU scheduling and help the guest make better scheduling > > decisions. > > > > > and entitlement to give to the guest indications on the host > > > vCPUs scheduling and help the guest take the best decisions > > > on the scheduling of threads on the vCPUs. > > > > > > Let us provide the SMP properties with books and drawers levels > > > and S390 CPU with dedication and entitlement, > > > > > > Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx> > > > --- > > > qapi/machine-common.json | 22 +++++++++++++ > > > qapi/machine.json | 21 ++++++++++--- > > > include/hw/boards.h | 10 +++++- > > > include/hw/qdev-properties-system.h | 4 +++ > > > target/s390x/cpu.h | 6 ++++ > > > hw/core/machine-smp.c | 48 > > > ++++++++++++++++++++++++--- > > > -- > > > hw/core/machine.c | 4 +++ > > > hw/core/qdev-properties-system.c | 13 ++++++++ > > > hw/s390x/s390-virtio-ccw.c | 2 ++ > > > softmmu/vl.c | 6 ++++ > > > target/s390x/cpu.c | 7 +++++ > > > qapi/meson.build | 1 + > > > qemu-options.hx | 7 +++-- > > > 13 files changed, 137 insertions(+), 14 deletions(-) > > > create mode 100644 qapi/machine-common.json > > > > > > diff --git a/qapi/machine-common.json b/qapi/machine-common.json > > > new file mode 100644 > > > index 0000000000..bc0d76829c > > > --- /dev/null > > > +++ b/qapi/machine-common.json > > > @@ -0,0 +1,22 @@ > > > +# -*- Mode: Python -*- > > > +# vim: filetype=python > > > +# > > > +# This work is licensed under the terms of the GNU GPL, version > > > 2 or > > > later. > > > +# See the COPYING file in the top-level directory. > > > + > > > +## > > > +# = Machines S390 data types > > Common definitions for machine.json and machine-target.json > > > > > > [...]
