> From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Sent: Wednesday, July 19, 2023 2:11 PM
>
> On Wed, Jul 19, 2023 at 05:32:27AM +0000, Tian, Kevin wrote:
> > > From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> > > Sent: Saturday, July 15, 2023 6:46 AM
> > >
> > > @@ -165,30 +161,26 @@ static int kvm_vfio_group_add(struct
> kvm_device
> > > *dev, unsigned int fd)
> > > list_for_each_entry(kvg, &kv->group_list, node) {
> > > if (kvg->file == filp) {
> > > ret = -EEXIST;
> > > - goto err_unlock;
> > > + goto out_unlock;
> > > }
> > > }
> > >
> > > kvg = kzalloc(sizeof(*kvg), GFP_KERNEL_ACCOUNT);
> > > if (!kvg) {
> > > ret = -ENOMEM;
> > > - goto err_unlock;
> > > + goto out_unlock;
> > > }
> > >
> > > - kvg->file = filp;
> > > + kvg->file = get_file(filp);
> >
> > Why is another reference required here?
>
> Because the function now has a single exit point and the original
> reference is dropped unconditionally on exit. It looks cleaner than
> checking for non-zero "ret" and deciding whether the reference should be
> dropped or kept.
>
A comment is appreciated. otherwise,
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
