On Fri, 2023-07-14 at 15:28 +0300, Nikolay Borisov wrote: > > On 12.07.23 г. 11:55 ч., Kai Huang wrote: > > The TDX spec names all TDCALLs with prefix "TDG". Currently, the kernel > > doesn't follow such convention for the macros of those TDCALLs but uses > > prefix "TDX_" for all of them. Although it's arguable whether the TDX > > spec names those TDCALLs properly, it's better for the kernel to follow > > the spec when naming those macros. > > > > Change all macros of TDCALLs to make them consistent with the spec. As > > a bonus, they get distinguished easily from the host-side SEAMCALLs, > > which all have prefix "TDH". > > > > No functional change intended. > > > > Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx> > > --- > > arch/x86/coco/tdx/tdx.c | 22 +++++++++++----------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c > > index 5b8056f6c83f..de021df92009 100644 > > --- a/arch/x86/coco/tdx/tdx.c > > +++ b/arch/x86/coco/tdx/tdx.c > > @@ -15,11 +15,11 @@ > > #include <asm/pgtable.h> > > > > /* TDX module Call Leaf IDs */ > > -#define TDX_GET_INFO 1 > > -#define TDX_GET_VEINFO 3 > > -#define TDX_GET_REPORT 4 > > -#define TDX_ACCEPT_PAGE 6 > > -#define TDX_WR 8 > > +#define TDG_VP_INFO 1 > > +#define TDG_VP_VEINFO_GET 3 > > +#define TDG_MR_REPORT 4 > > +#define TDG_MEM_PAGE_ACCEPT 6 > > +#define TDG_VM_WR 8 > > > What branch is this patch set based off? Because the existing TDX_GET_* > defines are in arch/x86/include/asm/shared/tdx.h due to ff40b5769a50f ? > It was based on tip/x86/tdx, which didn't have above patch. I'll rebase to the Linus's tree for the next round since it now has all TDX patches anyway.