On Wed, Jun 14, 2023 at 1:03 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > We have a helper for this too, gfn_round_for_level(). Ooh, but this isn't storing > a gfn, it's storing a gpa. Naughty, naughty. Caught in mischief I didn't even realize I was committing :O Anyways, I've taken all the feedback you provided here. Although, > All that said, consuming fault->goal_level is unnecessary, and not be coincidence. > The *only* time KVM should bail to userspace is if KVM failed to faultin a 4KiB > page. Providing a hugepage is done opportunistically, it's never a hard requirement. > So throw away all of the above and see below. I wonder if my arm64 patch commits the same error. I'll send an email over there asking Oliver about it.
