On Wed, Jun 14, 2023 at 1:25 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > -static int __kvm_faultin_pfn(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault) > > +static int __kvm_faultin_pfn(struct kvm_vcpu *vcpu, > > + struct kvm_page_fault *fault, > > + bool nowait) > > More booleans!? Just say no! And in this case, there's no reason to pass in a > flag, just handle this entirely in __kvm_faultin_pfn(). Ah, thanks: that extra parameter is a holdover from forever ago where "nowait" was a special thing that was read by handle_error_pfn(). Done.