On Sun, Jun 25, 2023 at 12:22:15PM -0700, Nadav Amit wrote: > > > > On Jun 24, 2023, at 3:13 AM, Andrew Jones <andrew.jones@xxxxxxxxx> wrote: > > > >> +extern char vector_stub_start, vector_stub_end; > > > > These aren't used until the next patch. > > > >> + > >> +int backtrace_frame(const void *frame, const void **return_addrs, int max_depth) { > > > > '{' should be on its own line. I usually try to run the kernel's > > checkpatch since we use the same style (except we're even more forgiving > > for long lines). > > I usually do use checkpatch. I guess I got sloppy. I will fix these 2 issues. > > BTW: I used the get_maintainer script to get who to send the patches to and it > included the depreciated kvmarm@xxxxxxxxxxxxxxxxxxxxx <mailto:kvmarm@xxxxxxxxxxxxxxxxxxxxx> .. Ugh. Ah, thanks for pointing that out. It's safe to declare the depreciation peroid over. I just pushed a patch dropping it now. drew