Re: [PATCH] KVM: x86: Update the version number of SDM in comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 15, 2023 at 04:06:24PM +0800, Jun Miao wrote:
> A little optimized update version number of SDM and corresponding
> public date, making it more accurate to retrieve.
> 
> Signed-off-by: Jun Miao <jun.miao@xxxxxxxxx>
> ---
>  arch/x86/kvm/lapic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index d7639d126e6c..4c5493e08d2e 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -2260,7 +2260,7 @@ static int apic_mmio_write(struct kvm_vcpu *vcpu, struct kvm_io_device *this,
>  	/*
>  	 * APIC register must be aligned on 128-bits boundary.
>  	 * 32/64/128 bits registers must be accessed thru 32 bits.
> -	 * Refer SDM 8.4.1

I would suggest just remove this line.
And maybe, add "According to Intel SDM, " at the beginning of the comments.

> +	 * Refer SDM 11.4.1 (March 2023).

Referring a specific section is not encouraged, as the numbers of SDM's
sections always change.

B.R.
Yu



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux