Hi Shaoqin,
On Fri, Jun 09, 2023 at 06:59:53PM +0800, Shaoqin Huang wrote:
> Hi Oliver,
>
> I have a play with this series, the guest always hang when hotplug two more
> cpus, it seems the kvm_cpu_continue_vm forget to continue the current cpu.
Thanks for testing the series out. Heh, a bit of a silly bug on my part,
sorry about that.
> > +void kvm_cpu__pause_vm(struct kvm_cpu *vcpu)
> > +{
> > + /*
> > + * Mark the calling vCPU as paused to avoid waiting indefinitely for a
> > + * signal exit.
> > + */
> > + vcpu->paused = true;
> > + kvm__pause(vcpu->kvm);
> > +}
> > +
> > +void kvm_cpu__continue_vm(struct kvm_cpu *vcpu)
> > +{
> Here should add:
> vcpu->paused = false;
> > + kvm__continue(vcpu->kvm);
> > +}
> > +
LGTM, I'll stick this in v2.
> > int kvm_cpu__start(struct kvm_cpu *cpu)
> > {
> > sigset_t sigset;
>
> --
> Shaoqin
>
--
Thanks,
Oliver
