Re: [kvm-unit-tests PATCH v9 1/2] s390x: topology: Check the Perform Topology Function

[Pierre Morel <pmorel@xxxxxxxxxxxxx>]

On 5/22/23 13:15, Nico Boehr wrote:
> Quoting Pierre Morel (2023-05-19 13:22:35)
> [...]
> > diff --git a/s390x/topology.c b/s390x/topology.c
> > new file mode 100644
> > index 0000000..2acede0
> > --- /dev/null
> > +++ b/s390x/topology.c
> [...]
> > +static void check_privilege(int fc)
> > +{
> > +       unsigned long rc;
> > +
> > +       report_prefix_push("Privilege");
> > +       report_info("function code %d", fc);
> report() messages should be unique.
>
> Can you please make this a
>    report_prefix_pushf("Privileged fc %d", fc);
> and get rid of the report_info()?
>
> With this change:
>
> Reviewed-by: Nico Boehr <nrb@xxxxxxxxxxxxx>


Yes, thanks

Pierre