Re: [PATCH v9 vfio 2/7] vfio/pds: Initial support for pds_vfio VFIO driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/4/2023 10:26 AM, Jason Gunthorpe wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On Fri, Apr 21, 2023 at 06:06:37PM -0700, Brett Creeley wrote:

+static int
+pds_vfio_pci_probe(struct pci_dev *pdev,
+                const struct pci_device_id *id)
+{

This indenting scheme is not kernel style. I generally suggest people
run their code through clang-format and go through and take most of
the changes. Most of what it sugges for this series is good

This GNU style of left aligning the function name should not be
in the kernel.

Jason

I will align and fix it in the next revision. Thanks for the review.

Brett



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux