On Fri, Apr 21, 2023 at 06:06:37PM -0700, Brett Creeley wrote: > +static int > +pds_vfio_pci_probe(struct pci_dev *pdev, > + const struct pci_device_id *id) > +{ This indenting scheme is not kernel style. I generally suggest people run their code through clang-format and go through and take most of the changes. Most of what it sugges for this series is good This GNU style of left aligning the function name should not be in the kernel. Jason