On Thu, May 04, 2023, Yan Zhao wrote: > On Wed, May 03, 2023 at 11:28:50AM -0700, Sean Christopherson wrote: > > Use the MTRR macros to identify the ranges of possible MTRR MSRs instead > > What about using MTRR macros to replace other 0x200 in mtrr.c too? Ugh, yes, I 'll convert all of those in v2 (wow, there are a lot of them). Ooh, and I missed that once the SVM usage of kvm_mtrr_valid() goes away, that thing can be made a static function. There's quite a bit of cleanup that can be done in the mtrr.c code, I'll see if there's any other low hanging fruit that can be picked for this series.