On Tue, Feb 14, 2023, Like Xu wrote: > From: Like Xu <likexu@xxxxxxxxxxx> > > The AMD PerfMonV2 defines three registers similar to part of the Intel Drop the "The", i.e. just "AMD PerfMonV2 defines ..." > v2 PMU registers, including the GLOBAL_CTRL, GLOBAL_STATUS and > GLOBAL_OVF_CTRL MSRs. For better code reuse, this specific part of > the handling can be extracted to make it generic for X86 as a straight > code movement. State what the patch actually does, not what it could do, or what can be done. > Specifically, move the kvm_pmu_set/get_msr() hanlders of GLOBAL_STATUS, s/hanlders/handlers > GLOBAL_CTRL, GLOBAL_OVF_CTRL defined by intel to generic pmu.c and Intel > remove the callback function .pmc_is_globally_enabled, which is very > helpful to introduce the AMD PerfMonV2 code later. > > The new non-prefix pmc_is_globally_enabled() works well as legacy AMD What prefix? It was pmc_is_globally_enabled() before and it's pmc_is_globally_enabled() now?
