Re: [PATCH v6 07/12] KVM: arm64: Export kvm_are_all_memslots_empty()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 12, 2023, Marc Zyngier wrote:
> On Tue, 07 Mar 2023 03:45:50 +0000,
> Ricardo Koller <ricarkol@xxxxxxxxxx> wrote:
> > No functional change intended.
> 
> I wish people stopped adding this pointless sentence to commit
> messages. All changes have a functional change one way or another,
> unless you are only changing a comment.

The implied context is that there is no change in runtime functionality, which
does hold true for many changes.  I personally find the annotation helpful, both
for code review and when doing git archaeology.  If a changelog states that the
author doesn't/didn't intend a functional change, then _any_ change in (runtime)
functionality becomes a red flag, and for me, prompts a closer look regardless of
whether or not I have other concerns with the patch/commit.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux