On Tue, 07 Mar 2023 03:45:50 +0000, Ricardo Koller <ricarkol@xxxxxxxxxx> wrote: > > Export kvm_are_all_memslots_empty(). This will be used by a future > commit when checking before setting a capability. You're not exporting this function, you are making it globally visible, which is a very different things. Please keep "export" description for symbols that are actually exported to modules. > > No functional change intended. I wish people stopped adding this pointless sentence to commit messages. All changes have a functional change one way or another, unless you are only changing a comment. Yes, I've been guilty of writing that too, and I wish I didn't. Thanks, M. -- Without deviation from the norm, progress is not possible.
