On Tue, Mar 07, 2023, Vipin Sharma wrote: > On Tue, Mar 7, 2023 at 3:33 AM kernel test robot <lkp@xxxxxxxxx> wrote: > > > > Hi Vipin, > > > > Thank you for the patch! Perhaps something to improve: > > > > [auto build test WARNING on kvm/queue] > > [also build test WARNING on kvmarm/next linus/master v6.3-rc1 next-20230307] > > [cannot apply to mst-vhost/linux-next kvm/linux-next] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > All warnings (new ones prefixed by >>): > > > > >> arch/x86/kvm/mmu/mmu.c:676: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > > > vim +676 arch/x86/kvm/mmu/mmu.c > > > > 674 > > 675 /** > > > 676 * Caller should hold mutex lock corresponding to cache, if available. > > 677 */ > > I will fix it in the next version. Don't bother reworking the code/comment, I will likely have feedback that results in the demise of the comment altogether (comments that say "lock X must be held" are almost always flawed).
