Hi Vipin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvm/queue] [also build test WARNING on kvmarm/next linus/master v6.3-rc1 next-20230307] [cannot apply to mst-vhost/linux-next kvm/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vipin-Sharma/KVM-x86-mmu-Change-KVM-mmu-shrinker-to-no-op/20230307-064510 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue patch link: https://lore.kernel.org/r/20230306224127.1689967-4-vipinsh%40google.com patch subject: [Patch v4 03/18] KVM: x86/mmu: Track count of pages in KVM MMU page caches globally config: i386-randconfig-a003-20230306 (https://download.01.org/0day-ci/archive/20230307/202303071940.sFeQ4FpU-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/511e837798da25063830276b8a3345c7601c6459 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vipin-Sharma/KVM-x86-mmu-Change-KVM-mmu-shrinker-to-no-op/20230307-064510 git checkout 511e837798da25063830276b8a3345c7601c6459 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kvm/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303071940.sFeQ4FpU-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> arch/x86/kvm/mmu/mmu.c:676: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Caller should hold mutex lock corresponding to cache, if available. arch/x86/kvm/mmu/mmu.c:693: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Caller should hold mutex lock corresponding to kvm_mmu_memory_cache, if arch/x86/kvm/mmu/mmu.c:1404: warning: Function parameter or member 'kvm' not described in 'kvm_arch_mmu_enable_log_dirty_pt_masked' arch/x86/kvm/mmu/mmu.c:1404: warning: Function parameter or member 'slot' not described in 'kvm_arch_mmu_enable_log_dirty_pt_masked' arch/x86/kvm/mmu/mmu.c:1404: warning: Function parameter or member 'gfn_offset' not described in 'kvm_arch_mmu_enable_log_dirty_pt_masked' arch/x86/kvm/mmu/mmu.c:1404: warning: Function parameter or member 'mask' not described in 'kvm_arch_mmu_enable_log_dirty_pt_masked' vim +676 arch/x86/kvm/mmu/mmu.c 674 675 /** > 676 * Caller should hold mutex lock corresponding to cache, if available. 677 */ 678 static int mmu_topup_sp_memory_cache(struct kvm_mmu_memory_cache *cache, 679 int min) 680 { 681 int orig_nobjs, r; 682 683 orig_nobjs = cache->nobjs; 684 r = kvm_mmu_topup_memory_cache(cache, min); 685 if (orig_nobjs != cache->nobjs) 686 percpu_counter_add(&kvm_total_unused_cached_pages, 687 (cache->nobjs - orig_nobjs)); 688 689 return r; 690 } 691 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
