Re: [PATCH] Inter-VM shared memory PCI device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/09/2010 11:28 AM, Avi Kivity wrote:
On 03/09/2010 05:27 PM, Cam Macdonell wrote:


  Registers are used
for synchronization between guests sharing the same memory object when
interrupts are supported (this requires using the shared memory server).

How does the driver detect whether interrupts are supported or not?
At the moment, the VM ID is set to -1 if interrupts aren't supported,
but that may not be the clearest way to do things.  With UIO is there
a way to detect if the interrupt pin is on?

I suggest not designing the device to uio. Make it a good guest-independent device, and if uio doesn't fit it, change it.

You can always fall back to reading the config space directly. It's not strictly required that you stick to the UIO interface.

Why not support interrupts unconditionally? Is the device useful without interrupts?

You can always just have interrupts enabled and not use them if that's desired.

Regards,

Anthony Liguori
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux