Re: [PATCH v1 1/1] KVM: s390: pci: fix virtual-physical confusion on module unload/load

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 22, 2023 at 04:55:02PM +0100, Nico Boehr wrote:
> @@ -112,7 +112,7 @@ static int zpci_reset_aipb(u8 nisc)
>  		return -EINVAL;
>  
>  	aift->sbv = zpci_aif_sbv;
> -	aift->gait = (struct zpci_gaite *)zpci_aipb->aipb.gait;
> +	aift->gait = phys_to_virt(zpci_aipb->aipb.gait);
>  
>  	return 0;
>  }

With this change aift->gait would never be NULL. Does it work with line 125?

120 int kvm_s390_pci_aen_init(u8 nisc)
121 {
122         int rc = 0;
123 
124         /* If already enabled for AEN, bail out now */
125         if (aift->gait || aift->sbv)
126                 return -EPERM;




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux