> From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
> Sent: Tuesday, January 17, 2023 9:50 PM
>
> +tracks VFIO files (group or device) in use by the VM and features
> +of those groups/devices important to the correctness and acceleration
> +of the VM. As groups/device are enabled and disabled for use by the
"groups/devices"
> + KVM_DEV_VFIO_FILE_DEL: Remove a VFIO file (group/device) from VFIO-
> KVM device
> + tracking kvm_device_attr.addr points to an int32_t file descriptor
> for the VFIO group.
"for the VFIO file"
> - KVM_DEV_VFIO_GROUP_DEL: Remove a VFIO group from VFIO-KVM
> device tracking
> - kvm_device_attr.addr points to an int32_t file descriptor
> - for the VFIO group.
> - KVM_DEV_VFIO_GROUP_SET_SPAPR_TCE: attaches a guest visible TCE
> table
> + KVM_DEV_VFIO_FILE_SET_SPAPR_TCE: attaches a guest visible TCE table
> allocated by sPAPR KVM.
> kvm_device_attr.addr points to a struct::
btw do we want to mention the GROUP cmd alias here instead of
simply removing them?
> @@ -1396,15 +1396,26 @@ struct kvm_create_device {
>
> struct kvm_device_attr {
> __u32 flags; /* no flags currently defined */
> - __u32 group; /* device-defined */
> - __u64 attr; /* group-defined */
> + union {
> + __u32 group;
> + __u32 file;
> + }; /* device-defined */
> + __u64 attr; /* VFIO-file-defined or group-defined */
remove "VFIO-"
