On Tue, 17 Jan 2023 10:43:01 +0100 Marc Hartmayer <mhartmay@xxxxxxxxxxxxx> wrote: > Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> writes: > > > On Mon, 16 Jan 2023 18:57:55 +0100 > > Marc Hartmayer <mhartmay@xxxxxxxxxxxxx> wrote: > > > >> Use the C pre-processor for the linker script generation. For example, > >> this enables us the use of constants in the "linker scripts" `*.lds.S`. > > > > please explain that the original .lds scripts are being renamed to > > .lds.S, and that the .lds are now generated. > > Okay. > > > > >> > >> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx> > >> --- > >> .gitignore | 1 + > >> s390x/Makefile | 6 ++++-- > >> s390x/{flat.lds => flat.lds.S} | 0 > >> s390x/snippets/asm/{flat.lds => flat.lds.S} | 0 > >> s390x/snippets/c/{flat.lds => flat.lds.S} | 0 > >> 5 files changed, 5 insertions(+), 2 deletions(-) > >> rename s390x/{flat.lds => flat.lds.S} (100%) > >> rename s390x/snippets/asm/{flat.lds => flat.lds.S} (100%) > >> rename s390x/snippets/c/{flat.lds => flat.lds.S} (100%) > >> > >> diff --git a/.gitignore b/.gitignore > >> index 601822d67325..29f352c5ceb6 100644 > >> --- a/.gitignore > >> +++ b/.gitignore > >> @@ -31,3 +31,4 @@ cscope.* > >> /s390x/comm.key > >> /s390x/snippets/*/*.hdr > >> /s390x/snippets/*/*.*obj > >> +/s390x/**/*.lds > > > > why ** ? > > Because all of our linker scripts are generated now: > > s390x/snippets/(c|asm)/*.lds > > and > > s390x/*.lds > > […snip] > ok so I thought ** was a typo and you meant either * or */*, but it turns out ** is actual a special glob syntax in gitignore ignore my comments regarding ** :)