Re: [kvm-unit-tests PATCH 7/9] s390x: use C pre-processor for linker script generation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> writes:

> On Tue, 17 Jan 2023 10:43:01 +0100
> Marc Hartmayer <mhartmay@xxxxxxxxxxxxx> wrote:
>
>> Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> writes:
>> 
>> > On Mon, 16 Jan 2023 18:57:55 +0100
>> > Marc Hartmayer <mhartmay@xxxxxxxxxxxxx> wrote:
>> >  
>> >> Use the C pre-processor for the linker script generation. For example,
>> >> this enables us the use of constants in the "linker scripts" `*.lds.S`.  
>> >
>> > please explain that the original .lds scripts are being renamed to
>> > .lds.S, and that the .lds are now generated.  
>> 
>> Okay.
>> 
>> >  
>> >> 
>> >> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx>
>> >> ---
>> >>  .gitignore                                  | 1 +
>> >>  s390x/Makefile                              | 6 ++++--
>> >>  s390x/{flat.lds => flat.lds.S}              | 0
>> >>  s390x/snippets/asm/{flat.lds => flat.lds.S} | 0
>> >>  s390x/snippets/c/{flat.lds => flat.lds.S}   | 0
>> >>  5 files changed, 5 insertions(+), 2 deletions(-)
>> >>  rename s390x/{flat.lds => flat.lds.S} (100%)
>> >>  rename s390x/snippets/asm/{flat.lds => flat.lds.S} (100%)
>> >>  rename s390x/snippets/c/{flat.lds => flat.lds.S} (100%)
>> >> 
>> >> diff --git a/.gitignore b/.gitignore
>> >> index 601822d67325..29f352c5ceb6 100644
>> >> --- a/.gitignore
>> >> +++ b/.gitignore
>> >> @@ -31,3 +31,4 @@ cscope.*
>> >>  /s390x/comm.key
>> >>  /s390x/snippets/*/*.hdr
>> >>  /s390x/snippets/*/*.*obj
>> >> +/s390x/**/*.lds  
>> >
>> > why ** ?  
>> 
>> Because all of our linker scripts are generated now:
>> 
>> s390x/snippets/(c|asm)/*.lds
>> 
>> and
>> 
>> s390x/*.lds
>> 
>> […snip]
>> 
>
> I still don't understand why ** instead of just * ?

“A slash followed by two consecutive asterisks then a slash matches zero
or more directories. For example, "a/**/b" matches "a/b", "a/x/b",
"a/x/y/b" and so on.” [1]

[1] https://git-scm.com/docs/gitignore

-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen 
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux