On Thu, Jan 12, 2023 at 10:25:06AM -0800, Atish Kumar Patra wrote: > On Thu, Jan 12, 2023 at 2:28 AM Andrew Jones <ajones@xxxxxxxxxxxxxxxx> wrote: > > > > On Thu, Dec 15, 2022 at 09:00:38AM -0800, Atish Patra wrote: > > > According to the SBI specification, the stop function can only > > > return error code SBI_ERR_FAILED. However, currently it returns > > > -EINVAL which will be mapped SBI_ERR_INVALID_PARAM. > > > > I presume the mapping referred to here is kvm_linux_err_map_sbi(). > > If so, then -EPERM isn't correct either. That maps to SBI_ERR_DENIED. > > The only thing that will ensure we get SBI_ERR_FAILURE (-1) is > > anything not handled by the kvm_linux_err_map_sbi switch, as we > > need to use the default. > > > > It returns SBI_ERR_FAILURE in the next patch when kvm_linux_err_map_sbi > is removed. Maybe I should drop this patch. The next patch does the > correct thing anyways. Yeah, I saw that, but then we silently fix a bug in the next patch. I like that this is a separate patch, but it should do what it says it's doing :-) Thanks, drew
