On Thu, Jan 12, 2023 at 10:18:05AM -0800, Atish Kumar Patra wrote: > On Thu, Jan 12, 2023 at 2:06 AM Andrew Jones <ajones@xxxxxxxxxxxxxxxx> wrote: > > > > On Thu, Dec 15, 2022 at 09:00:36AM -0800, Atish Patra wrote: ... > > > +EXPORT_SYMBOL(riscv_pmu_get_hpm_info); > > > > EXPORT_SYMBOL_GPL ? > > > > Is that mandatory ? I have seen usage of both in arch/riscv and other > places though. > I am also not sure if any other non-GPL module should/need access to this. TBH, I'm not sure what the best policy is, but I presumed we should use _GPL when we aren't aware of anything non-GPL and then when a day comes that something non-GPL would like this to be exported, the patch that flips it will provide the justification in its commit message. Thanks, drew
