On Tue, Jan 03, 2023 at 03:04:01PM +0100, Nina Schoetterl-Glausch wrote:
> On Mon, 2022-12-26 at 19:41 +0100, Andrew Jones wrote:
> > On Wed, Dec 21, 2022 at 10:14:52AM +0100, Nico Boehr wrote:
> > > Quoting Nico Boehr (2022-12-21 09:16:51)
> > > > Quoting Claudio Imbrenda (2022-12-20 18:55:08)
> > > > > A recent patch broke make standalone. The function find_word is not
> > > > > available when running make standalone, replace it with a simple grep.
> > > > >
> > > > > Reported-by: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx>
> > > > > Fixes: 743cacf7 ("s390x: don't run migration tests under PV")
> > > > > Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
> > > >
> > > > I am confused why find_word would not be available in standalone, since run() in runtime.bash uses it quite a few times.
> > > >
> > > > Not that I mind the grep, but I fear more might be broken in standalone?
> >
> > standalone tests don't currently include scripts/$ARCH/func.bash, which
> > may be an issue for s390x. That could be fixed, though.
> >
> > > >
> > > > Anyways, to get this fixed ASAP:
> > > >
> > > > Acked-by: Nico Boehr <nrb@xxxxxxxxxxxxx>
> > >
> > > OK, I get it now, find_word is not available during _build time_.
> >
> > That could be changed, but it'd need to be moved to somewhere that
> > mkstandalone.sh wants to source, which could be common.bash, but
> > then we'd need to include common.bash in the standalone tests. So,
>
> What is wrong with including common.bash?
for_each_unittest() isn't something that standalone tests need and,
theoretically, other non-standalone related functions could be introduced
there. Packaging functions for standalone tests which aren't needed by
the standalone tests isn't super clean. But, it's not really a problem
either.
Thanks,
drew
>
> > a new file for find_word() would be cleaner, but that sounds like
> > overkill.
> >
> > Thanks,
> > drew
> >
> > >
> > > Please make this a:
> > >
> > > Reviewed-by: Nico Boehr <nrb@xxxxxxxxxxxxx>
>
