Re: [kvm-unit-tests PATCH v1 1/1] s390x: fix make standalone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Nico Boehr (2022-12-21 09:16:51)
> Quoting Claudio Imbrenda (2022-12-20 18:55:08)
> > A recent patch broke make standalone. The function find_word is not
> > available when running make standalone, replace it with a simple grep.
> > 
> > Reported-by: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx>
> > Fixes: 743cacf7 ("s390x: don't run migration tests under PV")
> > Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
> 
> I am confused why find_word would not be available in standalone, since run() in runtime.bash uses it quite a few times.
> 
> Not that I mind the grep, but I fear more might be broken in standalone?
> 
> Anyways, to get this fixed ASAP:
> 
> Acked-by: Nico Boehr <nrb@xxxxxxxxxxxxx>

OK, I get it now, find_word is not available during _build time_.

Please make this a:

Reviewed-by: Nico Boehr <nrb@xxxxxxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux