On Fri, 16 Dec 2022 at 22:09, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote: > > 'NEED_CPU_H' guard target-specific code; it is defined by meson > altogether with the 'CONFIG_TARGET' definition. Since the latter > name is more meaningful, directly use it. > > Inspired-by: Peter Maydell <peter.maydell@xxxxxxxxxx> > Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> This feels to me like it's overloading the meaning of CONFIG_TARGET, which at the moment is "the string which names the header file with target-specific config definitions". I think I'd rather we just renamed NEED_CPU_H to something a bit clearer, like perhaps COMPILING_PER_TARGET (better suggestions welcome). thanks -- PMM
